Support Rust 2018 style imports#5
Open
yvt wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes
parse-generics-shimcompatible with Rust 2018 style imports. The introduced changes are twofold:local_inner_macrosto macro definitions so that they can be imported with Rust 2018 style imports. This is demonstrated intests/parse_constr.rs.cratename::aaa:bbb!).As it stands,
use-parse-generics-pocappears to be incompatible with any compiler version that is compatible with Rust 2018 style imports. The only way to useuse-parse-generics-pocnow is to grab a very ancient version of nightly, which is very unlikely for anyone to do these days. Thus, I think it's acceptable to ignoreuse-parse-generics-pocfor now, at least until it's rewritten as modern procedural macros.